Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] P2P: Track sync time to know when to allow a new start sync #590

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 19, 2024

Track when syncing starts as a backup determination on when to allow a new sync to begin. This continues to prevent multiple syncs to be kicked off from different connections at the same time. It works around a race condition on a connection syncing but with no active sync timer running.

Resolves #583

@heifner heifner changed the base branch from main to release/1.0 August 19, 2024 21:21
@heifner heifner requested review from greg7mdp and arhag August 19, 2024 21:22
@heifner heifner added the OCI Work exclusive to OCI team label Aug 19, 2024
@heifner heifner merged commit d54c4c1 into release/1.0 Aug 19, 2024
71 checks passed
@heifner heifner deleted the GH-583-sync-timeout branch August 19, 2024 23:33
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Optimize P2P syncing, tracking time to know when to start a new sync.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P: Sync not making progress after a timeout and reassign_fetch
4 participants